Reviewer's Guide

In extractFiles, this PR refactors the password prompt flow to track and handle consecutive wrong-password attempts for the same archive entry, preventing false error signals when a correct password is supplied.

Sequence diagram for improved password error handling in extractFiles

sequenceDiagram
    participant Plugin as LibzipPlugin
    participant Archive as zip archive
    participant User as actor User
    participant Query as PasswordNeededQuery

    Plugin->>Archive: Attempt to extract entry[i]
    alt Password required or wrong password
        Plugin->>Query: Emit signalQuery for password
        User->>Query: Enter password
        Query->>Plugin: Return password
        Plugin->>Archive: Set password and retry
        alt Password still wrong for same entry
            Plugin->>Archive: Close archive
            Plugin->>User: Show password error
        else Password correct
            Plugin->>Archive: Continue extraction
        end
    else No password needed
        Plugin->>Archive: Continue extraction
    end

Class diagram for updated LibzipPlugin password handling

classDiagram
    class LibzipPlugin {
        +extractFiles(files, options)
        -m_eErrorType
        -m_strPassword
        -lastNeedPasswordIndex
    }
    class PasswordNeededQuery {
        +password()
        +waitForResponse()
    }
    LibzipPlugin "1" -- "*" PasswordNeededQuery: emits signalQuery

File-Level Changes

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment